fix: improve confusing TS1107 error for mislabeled jump targets#63256
Open
AkaHarshit wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: improve confusing TS1107 error for mislabeled jump targets#63256AkaHarshit wants to merge 1 commit intomicrosoft:mainfrom
AkaHarshit wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Improve diagnostics by not eagerly reporting 'Jump target cannot cross function boundary' until encountering the actual target label. This correctly emits the TS1104 or TS1116 errors if the target lacks an enclosing iteration or switch statement. Fixes: microsoft#30408
|
@AkaHarshit please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Prior to this fix, the TypeScript compiler would eagerly output the confusing error
TS1107: Jump target cannot cross function boundary.whenever a jump target check reached a function boundary, even if the label existed nowhere in the code and should just be a regular "invalid label target" error.Solution
Modified
checkGrammarBreakOrContinueStatementinsidesrc/compiler/checker.tsto keep traversing the ancestor chain while remembering that a function boundary was crossed. If it actually finds the label after crossing a function boundary, only then will it outputTS1107. Otherwise, it falls back to the native label missing errors such asTS1104orTS1116.Testing
tests/cases/compiler/issue30408.tscontaining the reproduction code.Fixes: #30408