Add nbconvert to test-optional and change CI runner to macOS in Playwright workflow#8712
Open
Add nbconvert to test-optional and change CI runner to macOS in Playwright workflow#8712
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s test/CI setup by adding a missing notebook-conversion dependency for optional tests and changing the GitHub Actions Playwright job to run on macOS.
Changes:
- Add
nbconvert>=7.17.0to thetest-optionaldependency group (supporting notebook export-related tests). - Switch the Playwright GitHub Actions job runner from
ubuntu-latesttomacos-latest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pyproject.toml |
Adds nbconvert to optional test dependencies for ipynb-related exporting/testing. |
.github/workflows/playwright.yml |
Moves Playwright CI execution to macOS runners. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if: ${{ needs.changes.outputs.playwright == 'true' }} | ||
| timeout-minutes: 18 # 2024-01-18 avg: 5.0m max: 7.0m | ||
| runs-on: ubuntu-latest | ||
| runs-on: macos-latest |
Comment on lines
36
to
38
| timeout-minutes: 18 # 2024-01-18 avg: 5.0m max: 7.0m | ||
| runs-on: ubuntu-latest | ||
| runs-on: macos-latest | ||
| defaults: |
manzt
previously approved these changes
Mar 16, 2026
BSD sed on macOS requires -i '' (empty extension). Playwright cache on macOS is at ~/Library/Caches/ms-playwright, not ~/.cache/.
Light2Dark
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.