Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
the
documentation
Light2Dark
changed the title
There was a problem hiding this comment.
Pull request overview
Enables the (experimental) Storage Inspector / Remote Storage UI and corresponding kernel broadcasts by default when the user has not explicitly set experimental.storage_inspector.
Changes:
- Frontend: default
experimental.storage_inspectorfeature flag set totrue. - Backend: introduced
STORAGE_INSPECTOR_DEFAULT = Trueand used it as the fallback whenexperimental.storage_inspectoris unset, enabling storage namespace broadcasts by default. - Docs: updated Remote Storage guide to reflect default-on behavior and how to disable it.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| marimo/_runtime/runtime.py | Use backend default constant when deciding whether to register the storage broadcast post-execution hook. |
| marimo/_pyodide/pyodide_session.py | Same defaulting behavior as native runtime for Pyodide kernels. |
| marimo/_config/config.py | Adds STORAGE_INSPECTOR_DEFAULT constant for backend defaulting behavior. |
| frontend/src/core/config/feature-flag.tsx | Flips storage_inspector default to true for UI feature gating. |
| docs/guides/working_with_data/remote_storage.md | Updates docs to note default-on behavior and how to disable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
nit: obstore should not be capitalized (you can see this in their docs)
Why let users disable remote storage? Are we not confident in its correctness or performance?
- Set storage_inspector default to true in frontend feature-flag.tsx - Add STORAGE_INSPECTOR_DEFAULT constant in config.py and use in runtime and pyodide_session when experimental.storage_inspector is unset - Update remote_storage.md to note feature is on by default Made-with: Cursor
Light2Dark
force-pushed
the
sham/enable-storage-inspector-by-default
branch
from
7301e4c to
6239c6c
Compare
I think it's safe to release, but opting to be more defensive and get more feedback (since it's documented as experimental). We can remove the feat flag in subsequent release imo. Thanks for the obstore correction |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.20.5-dev74 |
Enables the experimental storage inspector for all users by default.
Users can still disable it via Settings > Experimental > Storage Inspector.