Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes uv-related runtime tests by forcing UvPackageManager.is_in_uv_project to False, avoiding environment-dependent behavior (e.g., when running tests under tooling that makes uv project detection always true).
Changes:
- Patch
UvPackageManager.is_in_uv_projecttoFalsein script-metadata management tests. - Patch
UvPackageManager.is_in_uv_project(and_uv_bin) in theuv pip installtest to ensure deterministic command selection/format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/_runtime/test_manage_script_metadata.py | Forces non-uv-project behavior for uv script-metadata tests to prevent env-dependent failures. |
| tests/_runtime/packages/test_package_managers.py | Forces uv pip install codepath (and a stable _uv_bin) so the expected command is consistent across environments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mscolnick
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
is_in_uv_projectalways returns true now- so we it patch it in relevant tests