Skip to content

clamp the height and add overflow for storage inspector error#8647

Merged
mscolnick merged 1 commit intomainfrom
sham/clamp-error-message-and-overflow
Mar 11, 2026
Merged

clamp the height and add overflow for storage inspector error#8647
mscolnick merged 1 commit intomainfrom
sham/clamp-error-message-and-overflow

Conversation

@Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Mar 11, 2026

📝 Summary

image

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.

@Light2Dark Light2Dark requested a review from manzt as a code owner March 11, 2026 18:22
Copilot AI review requested due to automatic review settings March 11, 2026 18:22
@vercel
Copy link

vercel bot commented Mar 11, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Mar 11, 2026 6:23pm

Request Review

Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Storage Inspector’s error rendering so long error messages don’t expand the panel indefinitely, improving usability in the storage connections UI.

Changes:

  • Adds a max height constraint to the storage inspector error state.
  • Enables scrolling for overflowed error content and aligns content to the top.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Light2Dark Light2Dark added the bug Something isn't working label Mar 11, 2026
@mscolnick mscolnick merged commit 2a130a2 into main Mar 11, 2026
33 of 34 checks passed
@mscolnick mscolnick deleted the sham/clamp-error-message-and-overflow branch March 11, 2026 22:02
@github-actions
Copy link

github-actions bot commented Mar 11, 2026

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.20.5-dev43

dmadisetti pushed a commit that referenced this pull request Mar 11, 2026
@Light2Dark @dmadisetti
clamp the height and add overflow for storage inspector error (#8647)
8012192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mscolnick mscolnick mscolnick approved these changes

@manzt manzt Awaiting requested review from manzt manzt is a code owner

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Light2Dark @mscolnick