only display "Jump to page" when >100 pages#8563
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
reviewed
Mar 4, 2026
| data-testid="page-jump-input" | ||
| /> | ||
| </div> | ||
| {totalPages > 50 && ( |
Contributor
There was a problem hiding this comment.
why 50? should it be based on when we do the clamping (which might be 50?)
Collaborator
Author
There was a problem hiding this comment.
We clamp at 100, but I felt 50 was a good number so you don't have to scroll too much. We could change later I think
I've updated to 100
Light2Dark
changed the title
mscolnick
approved these changes
Mar 4, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.20.5-dev5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
100 is chosen because that's the clamping point where we introduce ellipsis.
🔍 Description of Changes
📋 Checklist