Skip to content

fix pdb arrow navigation#8543

Merged
Light2Dark merged 1 commit intomainfrom
sham/fix-pdb-arrow-navigation
Mar 3, 2026
Merged

fix pdb arrow navigation#8543
Light2Dark merged 1 commit intomainfrom
sham/fix-pdb-arrow-navigation

Conversation

@Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Mar 3, 2026

📝 Summary

Fix #7604

The issue was useInputHistory was called per rendering of the component, meaning the history state only exists within itself. The state was not persisted. The solution is to hoist the state up to the parent.

added tests to verify the component works.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.

@Light2Dark Light2Dark requested a review from manzt as a code owner March 3, 2026 10:09
@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Mar 3, 2026 3:45pm

Request Review

@Light2Dark Light2Dark added the bug Something isn't working label Mar 3, 2026
@mscolnick mscolnick requested a review from dmadisetti as a code owner March 3, 2026 13:28
mscolnick
mscolnick previously approved these changes Mar 3, 2026
@Light2Dark Light2Dark merged commit 30ebab0 into main Mar 3, 2026
28 checks passed
@Light2Dark Light2Dark deleted the sham/fix-pdb-arrow-navigation branch March 3, 2026 17:05
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.20.3-dev90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support pdb up and down arrows for command history navigation

2 participants