storage-inspector: When parent dir is searched, child files should be open too#8525
Merged
storage-inspector: When parent dir is searched, child files should be open too#8525
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manzt
previously approved these changes
Mar 2, 2026
Collaborator
manzt
left a comment
There was a problem hiding this comment.
Nice, super minor comment/question.
| const name = displayName(entry.path); | ||
| const hasSearch = !!searchValue.trim(); | ||
|
|
||
| const selfMatches = |
Collaborator
There was a problem hiding this comment.
I wonder if instead of threading parentMatched through both components, we could just clear searchValue for children of a matched directory:
const selfMatches =
isDir && hasSearch && name.toLowerCase().includes(searchValue.trim().toLowerCase());
<StorageEntryChildren
...
searchValue={selfMatches ? "" : searchValue}
/>Shouldn't filterEntries already return everything when search is empty? Only difference is subdirectories under a matched parent won't auto-expand.
Collaborator
Author
There was a problem hiding this comment.
that's a much simpler fix, thank you!
mscolnick
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a search would only match exact files, so if a directory matched, children files would not show.
This fixes that

📋 Checklist