Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manzt
reviewed
Mar 2, 2026
Collaborator
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
Nice. Just a minor nit re: protocol matching.
| """Detect the storage provider from an endpoint URL.""" | ||
| url = url.strip().lower() | ||
| for pattern, protocol in _URL_PATTERNS: | ||
| if pattern in url: |
Collaborator
There was a problem hiding this comment.
This substring matching seems fragile. A URL like s3.cloudflare.com would match "s3" if the order changed, right? Maybe we consider matching against the hostname only, or using more specific patterns? Or document the expected behavior in tests.
Collaborator
Author
There was a problem hiding this comment.
I've added to tests and a comment that the order matters. I agree, but I don't have much data to infer what the urls would look like 🤔, so opted for the simpler approach.
mscolnick
approved these changes
Mar 3, 2026
Light2Dark
force-pushed
the
sham/improve-storage-protocol-detection
branch
from
aad64b0 to
5dca8a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Checks the endpoint URL to see if a more specific protocol can be found
🔍 Description of Changes
📋 Checklist