Show smart previews for SQL and markdown cells in minimap#8466
Merged
Conversation
Fixes #8457 The dependency minimap previously showed the raw first line of every cell, which meant SQL and markdown cells displayed unhelpful boilerplate like `mo.md(f"""` or `_df = mo.sql(f"""`. These changes extract the inner content (using smart-cells helpers) to show the first meaningful line instead. We could consider some alternative preview (e.g., a summary comment or visual indicator of cell type), but my experiments led to a lot of visual noise/clutter.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
Light2Dark
approved these changes
Feb 25, 2026
Comment on lines
+10
to
+11
| const markdownParser = new MarkdownParser(); | ||
| const sqlParser = new SQLParser(); |
Collaborator
There was a problem hiding this comment.
one alternative, but I think your solution is better, is to pull LanguageAdapters.markdown.transformIn
but I think the sql one has side effects.
Collaborator
|
CI failure is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8457
The dependency minimap previously showed the raw first line of every cell, which meant SQL and markdown cells displayed unhelpful boilerplate like
mo.md(f"""or_df = mo.sql(f""". These changes extract the inner content (using smart-cells helpers) to show the first meaningful line instead.We could consider some alternative preview (e.g., a summary comment or visual indicator of cell type), but my experiments led to a lot of visual noise/clutter and if found the stripping simple & effective.