Fix SQL cell deps lost when duckdb fails to parse normalized SQL#8437
Merged
Fix SQL cell deps lost when duckdb fails to parse normalized SQL#8437
Conversation
Fixes #8436 SQL cells use duckdb to split multi-statement queries before extracting refs with sqlglot. When duckdb couldn't parse the SQL, we bailed out entirely and could lose dependency information. Now when duckdb parsing fails, we fall through to sqlglot on the full SQL string instead of returning early, which can still salvage table refs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
for more information, see https://pre-commit.ci
mscolnick
previously approved these changes
Feb 23, 2026
Contributor
mscolnick
left a comment
mscolnick
left a comment
There was a problem hiding this comment.
thanks for the fix. this is definitely more correct
Collaborator
Author
Some failing tests... looking into it |
mscolnick
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8436
SQL cells use duckdb to split multi-statement queries before extracting
refs with sqlglot. When duckdb couldn't parse the SQL, we bailed out
entirely and could lose dependency information. Now when duckdb parsing
fails, we fall through to sqlglot on the full SQL string instead of
returning early, which can still salvage table refs.