Skip to content

fix sql validation errors not cleared on cell-language switch#8388

Merged
mscolnick merged 3 commits intomainfrom
sham/fix-validation-errors-not-cleared
Feb 22, 2026
Merged

fix sql validation errors not cleared on cell-language switch#8388
mscolnick merged 3 commits intomainfrom
sham/fix-validation-errors-not-cleared

Conversation

@Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Feb 20, 2026

📝 Summary

When an SQL cell switches to Python, the validation errors can still appear. This PR adds a destroy method to the plugin that clears timeouts and validation errors whenever the plugin is removed.

example of issue:
image

Icon was also changed, DatabaseZap icon for In-Memory database.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.

@Light2Dark Light2Dark requested a review from manzt as a code owner February 20, 2026 07:40
@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Feb 20, 2026 2:31pm

Request Review

@mscolnick mscolnick merged commit 679d14e into main Feb 22, 2026
30 checks passed
@mscolnick mscolnick deleted the sham/fix-validation-errors-not-cleared branch February 22, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants