quote duckdb tables, schema with double quote#8387
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
akshayka
previously approved these changes
Feb 20, 2026
mscolnick
reviewed
Feb 22, 2026
| return "unknown" | ||
|
|
||
|
|
||
| def _quote_identifier(identifier: str) -> str: |
Contributor
There was a problem hiding this comment.
do you think it would be better to avoid quoting if possible? (more concise / cleaner) by only quoting when containing special chars? the downside is being smart can always lead to more issues
Collaborator
Author
There was a problem hiding this comment.
I think it should be safe, https://duckdb.org/docs/stable/sql/dialect/keywords_and_identifiers. We might miss certain special chars imo.
- Identifiers can be quoted using double-quote characters ("). Quoted identifiers can use any keyword, whitespace or special character, e.g., "SELECT" and " § 🦆 ¶ " are valid identifiers.
- Double quotes can be escaped by repeating the quote character, e.g., to create an identifier named IDENTIFIER "X", use "IDENTIFIER ""X""".
mscolnick
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #8380. Quotes duckdb tables with double-quotes to avoid special characters affecting the query.
DESCRIBE schema.name.table->DESCRIBE "schema.name"."table"🔍 Description of Changes
📋 Checklist