fix: include xfailed and xpassed in pytest summary counts#8220
Merged
mscolnick merged 1 commit intomarimo-team:mainfrom Feb 10, 2026
Merged
fix: include xfailed and xpassed in pytest summary counts#8220mscolnick merged 1 commit intomarimo-team:mainfrom
mscolnick merged 1 commit intomarimo-team:mainfrom
Conversation
The marimo pytest summary only tracked passed, failed, errors, and skipped tests. Tests marked with @pytest.mark.xfail were not counted, making the total misleading (e.g. "Total: 0" when an xfail test ran). Add xfailed and xpassed fields to MarimoPytestResult and collect them from pytest's terminal reporter stats. These are shown conditionally in the summary (only when non-zero) to keep the output clean. Closes marimo-team#7665
Collaborator
|
Missing an explicit test for |
mscolnick
approved these changes
Feb 10, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.10-dev32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pytest summary counts didn't include
xfailedandxpassedresults, making the total inaccurate. Adds both fields and includes them in the summary total.Closes #7665
Test Plan