Fix spurious "truth value of UIElement" warning for anywidgets#8148
Merged
Fix spurious "truth value of UIElement" warning for anywidgets#8148
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
previously approved these changes
Feb 5, 2026
The `from_anywidget` cache lookup used `if not (el := _cache.get(widget))` which evaluates the truthiness of the cached UIElement on subsequent lookups. Since UIElement.__bool__ writes a warning to stderr, displaying the same anywidget in multiple cells would trigger the misleading message "The truth value of a UIElement is always True. You probably want to call `.value` instead." Switching to `is None` avoids the boolean coercion entirely.
manzt
force-pushed
the
push-qyxvmnrxlnlt
branch
from
43beda8 to
8d3ad2c
Compare
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.8-dev48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
from_anywidgetcache lookup usedif not (el := _cache.get(widget))which evaluates the truthiness of the cached UIElement on subsequent lookups. SinceUIElement.__bool__writes a warning to stderr, displaying the same anywidget in multiple cells would trigger the misleading message "The truth value of a UIElement is always True. You probably want to call.valueinstead."