Skip to content

fix: top-level defs showing up in wasm#8138

Merged
mscolnick merged 1 commit intomainfrom
ms/fix-top-level-defs-showing-up-in-wasm
Feb 5, 2026
Merged

fix: top-level defs showing up in wasm#8138
mscolnick merged 1 commit intomainfrom
ms/fix-top-level-defs-showing-up-in-wasm

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Feb 5, 2026

Top-level defs were not showing up since we didn't pass down the proper hook.

I am doing a refactor in a followup for better hook management

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Feb 5, 2026 4:49pm

Request Review

Copy link
Collaborator

@dmadisetti dmadisetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mscolnick mscolnick merged commit 1c5c1ab into main Feb 5, 2026
50 of 53 checks passed
@mscolnick mscolnick deleted the ms/fix-top-level-defs-showing-up-in-wasm branch February 5, 2026 18:46
mscolnick added a commit that referenced this pull request Feb 9, 2026
Move kernel hooks into an encapsulated class to avoid prop-drilling and
keep code consistent / clean. This maybe would've helped avoid
#8138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants