Skip to content

Require playwright installation for pdf export#8121

Merged
mscolnick merged 2 commits intomainfrom
sham/force-playwright-installation-pdf-export
Feb 5, 2026
Merged

Require playwright installation for pdf export#8121
mscolnick merged 2 commits intomainfrom
sham/force-playwright-installation-pdf-export

Conversation

@Light2Dark
Copy link
Collaborator

This is a tradeoff to make, not all users may have playwright installed. On the other hand, webpdf is generally more resilient to errors.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Feb 4, 2026 3:48pm

Request Review

@Light2Dark Light2Dark added the enhancement New feature or request label Feb 4, 2026
@mscolnick mscolnick merged commit e7c580b into main Feb 5, 2026
42 of 45 checks passed
@mscolnick mscolnick deleted the sham/force-playwright-installation-pdf-export branch February 5, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants