Skip to content

fix setting UI config to empty for AI custom & displayed models#7991

Merged
mscolnick merged 1 commit intomainfrom
sham/fix-ai-config-not-updating-empty-array
Jan 27, 2026
Merged

fix setting UI config to empty for AI custom & displayed models#7991
mscolnick merged 1 commit intomainfrom
sham/fix-ai-config-not-updating-empty-array

Conversation

@Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Jan 27, 2026

📝 Summary

There is a bug where untoggling providers/models would not save the config. It's because RHF does not consider them dirty (they have returned to default values). This adds some manual tracking for certain fields & injecting the config.

The other solution I explored was changing the API to be list[str] | "all" maybe, so default value is not empty list. But I am hesitant to make an API change.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jan 27, 2026 5:17am

Request Review

@Light2Dark Light2Dark added the bug Something isn't working label Jan 27, 2026
@Light2Dark Light2Dark marked this pull request as ready for review January 27, 2026 11:50
@Light2Dark Light2Dark requested a review from manzt as a code owner January 27, 2026 11:50
@mscolnick mscolnick merged commit c2f1e2f into main Jan 27, 2026
34 of 36 checks passed
@mscolnick mscolnick deleted the sham/fix-ai-config-not-updating-empty-array branch January 27, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants