Fix SQLite list type binding error when adding website#1214
Open
majiayu000 wants to merge 1 commit intollmware-ai:mainfrom
Open
Fix SQLite list type binding error when adding website#1214majiayu000 wants to merge 1 commit intollmware-ai:mainfrom
majiayu000 wants to merge 1 commit intollmware-ai:mainfrom
Conversation
When using SQLite as the database engine and adding a website via Library.add_website(), the user_tags field (a Python list) was being passed directly to SQLite, causing "Error binding parameter 22: type 'list' is not supported". This fix converts list-type user_tags to JSON strings before binding in both SQLiteWriter and PGWriter. Fixes llmware-ai#1042 Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_tagsto JSON strings before SQL parameter bindingTest plan
Fixes #1042
Signed-off-by: majiayu000 1835304752@qq.com