fix: show release tag in version command output#1859
Open
jnMetaCode wants to merge 3 commits intolightpanda-io:mainfrom
Open
fix: show release tag in version command output#1859jnMetaCode wants to merge 3 commits intolightpanda-io:mainfrom
version command output#1859jnMetaCode wants to merge 3 commits intolightpanda-io:mainfrom
Conversation
Add git_tag build option so release builds can pass the tag name. When available, `lightpanda version` prints the tag (e.g. v0.2.6) instead of just the commit hash. Closes lightpanda-io#1835 Signed-off-by: JiangNan <1394485448@qq.com>
When the build is triggered by a tag push, pass -Dgit_tag to zig build so the binary can display the release version in `lightpanda version`. Signed-off-by: JiangNan <1394485448@qq.com>
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1835
Problem
lightpanda versionalways prints the short commit hash (e.g.fe3faa0a), even on stable releases where the tag name (e.g.v0.2.6) would be more useful.Solution
Add a
git_tagbuild option that release builds can set. When present, the version command prints:When absent (dev/nightly builds), the output is unchanged:
Changes
git_tagbuild option, expose it viabuild_config-Dgit_tag=<tag>when the CI build is triggered by a tag push