Fix hardcoded URLs for private Cloud compatibility#95
Draft
JoshSalway wants to merge 4 commits intolaravel:mainfrom
Draft
Fix hardcoded URLs for private Cloud compatibility#95JoshSalway wants to merge 4 commits intolaravel:mainfrom
JoshSalway wants to merge 4 commits intolaravel:mainfrom
Conversation
laravel#38: The code path in BaseCommand::runUpdate() is reachable when CLI flags are passed in interactive mode and the user confirms. Removed the misleading "When would we ever get here?" comment. laravel#39: Added --dry-run flag to both deploy and ship commands. Shows what would happen (app, environment, branch, region, database type) without executing any API calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ntVariables Replace info($url) with a neutral message to prevent plaintext database credentials from being displayed in terminal output. Remove ~28 lines of commented-out code from EnvironmentVariables. Closes laravel#83 Closes laravel#84 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use self::FAILURE instead of integer 1 in InstanceDelete catch block for consistency with other delete commands (closes laravel#85) - Add early return in removeToken() when no tokens exist to prevent calling select() with empty options (closes laravel#86) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…for private Cloud compatibility Fixes two hardcoded documentation URLs in AuthToken and HasAClient that break when CLOUD_BASE_URL is set to a private instance. Adds a README section documenting the CLOUD_BASE_URL env var and private Cloud usage. Refs laravel#93 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://cloud.laravel.comURLs withconfig('app.base_url')so the "Learn how to create an API token" links resolve correctly whenCLOUD_BASE_URLis set to a private instanceCLOUD_BASE_URLenv varRefs #93
Status: DRAFT — needs guidance from maintainers
Question: Is Private Cloud a supported use case for the CLI?
CLOUD_BASE_URLenv var, per-instance config file storage, and API base URL resolution already work — these two info messages were the only places still hardcoded.What we cannot verify
The browser-based OAuth flow (
cloud auth) needs testing against a private instance — we have no way to confirm it works end-to-end. Thecloud auth:tokenmanual token path should work fine since it only hits the API via the already-configurable base URL.Changes
app/Commands/AuthToken.phpconfig('app.base_url')app/Concerns/HasAClient.phpconfig('app.base_url')README.mdTest plan
./vendor/bin/phpstan analysepasses with no errorscloud auth:tokenshows correct URL whenCLOUD_BASE_URLis setcloud auth:tokenshows default URL whenCLOUD_BASE_URLis not set🤖 Generated with Claude Code