Fix InstanceDelete return constant and AuthToken empty tokens guard#90
Open
JoshSalway wants to merge 3 commits intolaravel:mainfrom
Open
Fix InstanceDelete return constant and AuthToken empty tokens guard#90JoshSalway wants to merge 3 commits intolaravel:mainfrom
JoshSalway wants to merge 3 commits intolaravel:mainfrom
Conversation
laravel#38: The code path in BaseCommand::runUpdate() is reachable when CLI flags are passed in interactive mode and the user confirms. Removed the misleading "When would we ever get here?" comment. laravel#39: Added --dry-run flag to both deploy and ship commands. Shows what would happen (app, environment, branch, region, database type) without executing any API calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ntVariables Replace info($url) with a neutral message to prevent plaintext database credentials from being displayed in terminal output. Remove ~28 lines of commented-out code from EnvironmentVariables. Closes laravel#83 Closes laravel#84 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use self::FAILURE instead of integer 1 in InstanceDelete catch block for consistency with other delete commands (closes laravel#85) - Add early return in removeToken() when no tokens exist to prevent calling select() with empty options (closes laravel#86) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self::FAILUREinstead of integer1in the catch block for consistency with all other delete commands (closes Bug: InstanceDelete returns integer 1 instead of self::FAILURE constant #85)removeToken()when no tokens exist, preventingselect()from being called with empty options (closes Bug: AuthToken --remove with no tokens calls select() with empty options #86)Test plan
./vendor/bin/pest— 40 tests pass./vendor/bin/phpstan analyse— no errors🤖 Generated with Claude Code