fix: 8 reliability issues in cloud ship command#74
Open
JoshSalway wants to merge 5 commits intolaravel:mainfrom
Open
fix: 8 reliability issues in cloud ship command#74JoshSalway wants to merge 5 commits intolaravel:mainfrom
JoshSalway wants to merge 5 commits intolaravel:mainfrom
Conversation
Increases test coverage from 3/87 commands (~3%) to 43/87 (~49%), following the Laravel Forge CLI pattern of one test file per command. Commands now tested: - Auth: auth, auth:token - Application: create, get, update, delete - Environment: create, get, list, update, delete, variables - Domain: create, delete, list, verify - Database: cluster create/delete/list, database create/delete/list - Cache: create, delete, list - Bucket: create, delete, list - Instance: create, delete, list, update - WebSocket: cluster create/delete/list, application create/delete - Background Process: create, delete, list - Command: run, list Bugs documented in tests (skipped with references to PR laravel#42): - 7 commands catch wrong RequestException class (Illuminate vs Saloon) - ApplicationUpdate has no error handling for API failures - DatabaseDelete catches Throwable which swallows CommandExitException - DomainCreate missing non-interactive defaults - CacheDelete/BucketDelete missing --json option Refs laravel#41 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…3 files Coverage now at ~95% of commands (80/87). Remaining untested: Browser, Dashboard, Completions (utility commands that open browser/generate shell), Ship (tested via refactor PR laravel#54), and DeployMonitor (complex polling). New test files cover: - Application: list (expanded) - BackgroundProcess: get, update - Bucket: get, update - BucketKey: create, delete, get, list, update - Cache: get, types, update - Command: get - DatabaseCluster: get, update - Database: get, open, restore create - DatabaseSnapshot: create, delete, get, list - DedicatedCluster: list - Deployment: get, list - DeployMonitor: basic smoke test - Domain: get, update - EnvironmentLogs: basic test - Instance: get, sizes - IpAddresses: list, filter - AuthToken: list, reveal - WebSocket: app get/list/update, cluster get/update - RepoConfig: git detection Additional bugs found and filed: - laravel#55: DatabaseRestoreCreate completely broken (TypeError) - laravel#56: DatabaseSnapshotCreate missing CLI options - laravel#57: DatabaseClusterUpdate unusable non-interactively 352 tests, 381 assertions, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add global options to BaseCommand so that application and environment can be specified explicitly via --application and --environment flags, removing the requirement to run commands from within a matching project directory. The resolution priority is: explicit flag > local config > git remote/branch detection > interactive prompt. Closes laravel#61, refs laravel#62 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Implements the missing CLI commands for starting and stopping environments. The client code (EnvironmentsResource::start/stop and corresponding request classes) already existed — this adds the Artisan commands and tests. Closes laravel#65, relates to laravel#69 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Addresses critical, high, medium, and low severity bugs that affect reliability in both interactive and CI/non-interactive usage. Fixes laravel#73 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 8 reliability issues in
cloud shipthat affect both interactive and non-interactive usage. This is the flagship onboarding command — these fixes make the experience match its ambition.Closes #73
Context: This PR builds on other improvements
This work is part of a broader effort to make the CLI production-ready:
deployment:logscommandWhile this PR has several changes, each fix is surgical and targeted. The test suite (#43) validates nothing is broken.
Fixes
Critical
1.
waitForUrlToBeReadyinfinite loop — Added 120-second timeout and treats redirects as success. Previously, a 3xx/4xx response (common with CloudFlare, fresh deploys) caused the spinner to run forever.High
2. Non-interactive mode continues after "repo exists" error — Added
return self::FAILUREso execution stops instead of falling through to create a duplicate app.3.
$environment->instances[0]crash — AddedwaitForInstance()helper that polls until the instance is provisioned (60s timeout). Previously crashed with undefined offset when the instance was not yet ready.Medium
4. Database provisioning race condition — Retry handler now retries on any error during provisioning, not just "please wait" messages. Added max retry count.
5.
.envparse errors silently swallowed — Now showswarning()with the parse error message so users know their env vars were not imported.6.
confirm()prompt in non-interactive mode — Gated "Open site in browser?" behind$this->isInteractive()so it does not crash in CI.Low
7.
createApplicationNonInteractivelyno error handling — Wrapped in try/catch with friendly error message instead of raw stack trace.8.
tryToSetAvatarcatchesThrowabletoo broadly — Narrowed tocatch (RequestException)so genuine bugs are not silently swallowed.Test plan
./vendor/bin/pest— all 384 tests pass./vendor/bin/phpstan analyse— 0 errorscloud shipinteractively — should complete full flow without hangingcloud ship --no-interaction— should fail cleanly if repo already has an appGenerated with Claude Code