feat: add global --application and --environment flags#64
Open
JoshSalway wants to merge 3 commits intolaravel:mainfrom
Open
feat: add global --application and --environment flags#64JoshSalway wants to merge 3 commits intolaravel:mainfrom
JoshSalway wants to merge 3 commits intolaravel:mainfrom
Conversation
Increases test coverage from 3/87 commands (~3%) to 43/87 (~49%), following the Laravel Forge CLI pattern of one test file per command. Commands now tested: - Auth: auth, auth:token - Application: create, get, update, delete - Environment: create, get, list, update, delete, variables - Domain: create, delete, list, verify - Database: cluster create/delete/list, database create/delete/list - Cache: create, delete, list - Bucket: create, delete, list - Instance: create, delete, list, update - WebSocket: cluster create/delete/list, application create/delete - Background Process: create, delete, list - Command: run, list Bugs documented in tests (skipped with references to PR laravel#42): - 7 commands catch wrong RequestException class (Illuminate vs Saloon) - ApplicationUpdate has no error handling for API failures - DatabaseDelete catches Throwable which swallows CommandExitException - DomainCreate missing non-interactive defaults - CacheDelete/BucketDelete missing --json option Refs laravel#41 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…3 files Coverage now at ~95% of commands (80/87). Remaining untested: Browser, Dashboard, Completions (utility commands that open browser/generate shell), Ship (tested via refactor PR laravel#54), and DeployMonitor (complex polling). New test files cover: - Application: list (expanded) - BackgroundProcess: get, update - Bucket: get, update - BucketKey: create, delete, get, list, update - Cache: get, types, update - Command: get - DatabaseCluster: get, update - Database: get, open, restore create - DatabaseSnapshot: create, delete, get, list - DedicatedCluster: list - Deployment: get, list - DeployMonitor: basic smoke test - Domain: get, update - EnvironmentLogs: basic test - Instance: get, sizes - IpAddresses: list, filter - AuthToken: list, reveal - WebSocket: app get/list/update, cluster get/update - RepoConfig: git detection Additional bugs found and filed: - laravel#55: DatabaseRestoreCreate completely broken (TypeError) - laravel#56: DatabaseSnapshotCreate missing CLI options - laravel#57: DatabaseClusterUpdate unusable non-interactively 352 tests, 381 assertions, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add global options to BaseCommand so that application and environment can be specified explicitly via --application and --environment flags, removing the requirement to run commands from within a matching project directory. The resolution priority is: explicit flag > local config > git remote/branch detection > interactive prompt. Closes laravel#61, refs laravel#62 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--applicationand--environmentas global options on all commands viaBaseCommand::configure()Resolverscontainer toApplicationResolverandEnvironmentResolverExample usage
Changes
app/Commands/BaseCommand.php— adds global--applicationand--environmentoptions inconfigure(), passes them toResolversapp/Resolvers/Resolver.php— acceptsapplicationFlagandenvironmentFlagconstructor paramsapp/Resolvers/Resolvers.php— accepts and threads flag values to resolver instancesapp/Resolvers/ApplicationResolver.php— checksapplicationFlagbefore local config fallbackapp/Resolvers/EnvironmentResolver.php— checksenvironmentFlagbefore local config fallbackTest plan
./vendor/bin/phpstan analysepasses with no errors./vendor/bin/pestpasses (378 tests, 409 assertions)cloud environment:list --application=<name> --no-interactionresolves without git contextcloud command:list --application=<name> --environment=<name> --no-interactionresolves without git contextCloses #61, refs #62
🤖 Generated with Claude Code