feat: add --hide-secrets flag to redact connection credentials#63
Open
JoshSalway wants to merge 1 commit intolaravel:mainfrom
Open
feat: add --hide-secrets flag to redact connection credentials#63JoshSalway wants to merge 1 commit intolaravel:mainfrom
JoshSalway wants to merge 1 commit intolaravel:mainfrom
Conversation
The existing outputJsonIfWanted() method now applies recursive secret redaction when --hide-secrets is passed. This covers both environment variable key/value pairs (where the key looks sensitive) and named credential fields like password, secret, api_key, access_key, secret_key, token, and private_key in any nested structure. Closes laravel#60 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--hide-secretsoption toBaseCommandthat all commands inheritoutputJsonIfWanted()to recursively redact sensitive values when the flag is setpassword,secret,api_key,access_key,secret_key,secretAccessKey,token,private_key, etc.) in any nested structureDB_PASSWORD,APP_SECRET)********This addresses the issue where
cache:list,cache:get,database-cluster:get,bucket-key:get, and similar commands expose connection passwords and secrets in their JSON output. For example:{"connection": {"hostname": "...", "password": "plaintext"}}With
--hide-secrets:{"connection": {"hostname": "...", "password": "********"}}Closes #60
Test plan
vendor/bin/pest)vendor/bin/phpstan analyse)🤖 Generated with Claude Code