fix(sdk): strip leading slash from glob patterns before matching#1846
Merged
Maahir Sachdev (maahir30) merged 2 commits intomainfrom Mar 12, 2026
Merged
fix(sdk): strip leading slash from glob patterns before matching#1846Maahir Sachdev (maahir30) merged 2 commits intomainfrom
Maahir Sachdev (maahir30) merged 2 commits intomainfrom
Conversation
github-actions
bot
added
deepagents
Mason Daugherty (mdrxy)
changed the title
Eugene Yurtsev (eyurtsev)
approved these changes
Mar 12, 2026
Collaborator
Eugene Yurtsev (eyurtsev)
left a comment
Eugene Yurtsev (eyurtsev)
left a comment
There was a problem hiding this comment.
Do we have a test for composite backend?
Eugene Yurtsev (eyurtsev)
approved these changes
Mar 12, 2026
james8814
pushed a commit
to james8814/deepagents
that referenced
this pull request
Mar 13, 2026
…gchain-ai#1846) - Glob patterns with a leading `/` (e.g., `/foo/**/*.md`) never matched any files because the matching is done against relative paths. `pattern.lstrip("/")` normalizes the pattern so both sides are consistent. - Added two unit tests covering leading-slash patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/(e.g.,/foo/**/*.md) never matched any files because the matching is done against relative paths.pattern.lstrip("/")normalizes the pattern so both sides are consistent.