Conversation
…fault-redaction to default-safe-outputs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
March 15, 2026 19:54
View session
Contributor
|
At @copilot, delete all configuration and references related to allowed-URL-domains. Do not preserve backward compatibility and remove all legacy code paths. |
… entry Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in 4644ebb. Removed the deprecated |
…w * in network.allowed Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Fixed in ba62829. Three issues were causing failures:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
@copilot merge main |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges the safe-outputs.allowed-domains and safe-outputs.allowed-url-domains fields into a single allowed-domains field (which now supports ecosystem identifiers and unions with the network base set), and renames the default-redaction compound ecosystem to default-safe-outputs.
Changes:
- Removed
AllowedURLDomainsfield and its validation/parsing;allowed-domainsnow inherits the union + ecosystem expansion behavior thatallowed-url-domainshad. - Renamed
default-redactioncompound ecosystem todefault-safe-outputs, and renamed internal functions (expandAllowedURLDomains→expandAllowedDomains,computeAllowedURLDomainsForSanitization→computeExpandedAllowedDomainsForSanitization). - Tightened
isEcosystemIdentifierto use a strict regex and updated all 19 smoke workflow files.
Reviewed changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/compiler_types.go | Removed AllowedURLDomains field from SafeOutputsConfig |
| pkg/workflow/safe_outputs_config.go | Removed parsing of allowed-url-domains from frontmatter |
| pkg/workflow/safe_outputs_validation.go | Merged validation functions; tightened isEcosystemIdentifier regex; added * wildcard handling for network |
| pkg/workflow/domains.go | Renamed functions and default-redaction → default-safe-outputs |
| pkg/workflow/compiler.go | Removed validateSafeOutputsAllowedURLDomains call |
| pkg/workflow/compiler_yaml.go | Updated domain computation to use union approach for allowed-domains |
| pkg/workflow/compiler_safe_outputs_steps.go | Updated domain computation; removed strings import |
| pkg/workflow/domains_test.go | Updated test names and references |
| pkg/workflow/allowed_domains_sanitization_test.go | Updated tests for union behavior |
| pkg/workflow/compiler_safe_outputs_steps_test.go | Updated assertions for union output |
| pkg/parser/schemas/main_workflow_schema.json | Updated allowed-domains description; removed allowed-url-domains |
| .github/workflows/smoke-*.md | Updated from allowed-url-domains: [default-redaction] to allowed-domains: [default-safe-outputs] |
| .github/workflows/smoke-*.lock.yml | Recompiled lock files with new frontmatter hashes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
242
to
243
| // unions with network configuration (not overrides it) | ||
| func TestManualAllowedDomainsHasPriority(t *testing.T) { |
…-domains-fields # Conflicts: # .github/workflows/smoke-workflow-call.lock.yml
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
pelikhan
approved these changes
Mar 15, 2026
Contributor
…name test function Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Fixed in 2822da1. The test Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
github-actions bot
added a commit
that referenced
this pull request
Mar 16, 2026
…igger Add two new glossary entries based on recent changes: - Ecosystem Identifiers: Named shorthand references to predefined domain sets (python, node, go, github, dev-tools, local, default-safe-outputs) used in network.allowed and safe-outputs.allowed-domains. Includes the new default-safe-outputs compound ecosystem identifier (renamed from default-redaction in #21114). - Label Command Trigger (label_command): New trigger type from #21118 that activates when a specific label is added to an issue, PR, or discussion. The label is automatically removed on activation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the
safe-outputs.allowed-domainsandsafe-outputs.allowed-url-domainsfields into a singleallowed-domainsfield, and renames thedefault-redactioncompound ecosystem todefault-safe-outputs.Changes
Merged fields
AllowedURLDomainsfield fromSafeOutputsConfigstructallowed-domainsnow has the full capability of the oldallowed-url-domains:python,node,default-safe-outputs)validateSafeOutputsAllowedURLDomainsvalidation function (merged intovalidateSafeOutputsAllowedDomains)allowed-url-domainsfully removed from the JSON schema — no deprecated entry, no legacy support; workflows using it will now fail validationRenamed ecosystem
default-redactioncompound ecosystem →default-safe-outputsallowed-url-domains: [default-redaction]→allowed-domains: [default-safe-outputs]Code quality improvements
isEcosystemIdentifierto use a strict regex pattern (^[a-z][a-z0-9-]*$) instead of a loose structural check — prevents empty strings,*, and strings with spaces from being incorrectly classified as ecosystem identifiersexpandAllowedURLDomains→expandAllowedDomains,computeAllowedURLDomainsForSanitization→computeExpandedAllowedDomainsForSanitizationSchema
allowed-domainsdescription to mention ecosystem identifier supportallowed-url-domainsentirely (no backward compatibility preserved)Testing
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.