Migrate pkg/parser/frontmatter_helpers_test.go to testify assertions

[Copilot]

The only test file in pkg/parser/ not using testify — replaced 14 raw t.Fatal/t.Errorf calls and manual strings.Contains checks with require/assert, consistent with the rest of the package.

Changes

• Imports: removed "strings", added testify/assert and testify/require
• TestUpdateWorkflowFrontmatter:
  • t.Fatalf/t.Errorf → require.NoError / assert.Error
  • 3× strings.Contains + t.Errorf → assert.Contains
  • Added verbose bool field and a verbose=true test case that verifies the frontmatter update is applied correctly
• TestEnsureToolsSection: replaced 15-line manual nested-map comparison with assert.Equal; nil/type-assertion guards → require.NotNil / require.True
• TestReconstructWorkflowFile: t.Errorf + early return → require.NoError + assert.Equal
• TestQuoteCronExpressions: not added — already exists in quote_cron_expressions_test.go with 18 cases

Before / after (tools verification):

// Before
if !strings.Contains(content, "new-tool:") {
    t.Errorf("Expected 'new-tool:' in updated content, got: %s", content)
}

// After
assert.Contains(t, content, "new-tool:", "updated file should contain the new tool key")

// Before — 15 lines of manual map walking
for key, expectedValue := range tt.expectedTools {
    if actualValue, exists := tools[key]; !exists {
        t.Errorf("Expected tool '%s' not found", key)
    } else { ... }
}

// After
assert.Equal(t, tt.expectedTools, tools, "tools section should match expected state")

[Copilot]

Pull request overview

Migrates pkg/parser/frontmatter_helpers_test.go to use testify/assert and testify/require for more consistent, readable test assertions across pkg/parser.

Changes:

• Replaced t.Fatal/t.Errorf and manual strings.Contains checks with require/assert.
• Added a new “verbose” test case wiring through the verbose argument to UpdateWorkflowFrontmatter.
• Simplified EnsureToolsSection verification by using assert.Equal and require guards.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[pelikhan]

@copilot apply comments

[Copilot]

@copilot apply comments

Done in fa6f75a:

1. Removed unused expectedContent — field and all populated values dropped from the struct; no dead strings remain.
2. Verbose test renamed + stderr captured — case is now "Verbose mode emits info message to stderr" and uses testutil.CaptureStderr to assert "Updated workflow file" appears in stderr, then checks the frontmatter update was actually applied.
3. Reference identity proved by mutation — replaced the misleading assert.Equal(frontmatterTools, tools, "same reference…") with a probe: inserts a sentinel key into tools and asserts it's visible via frontmatter["tools"], which only passes if they're the same underlying map.