C#: Reduce reliance on CFG nodes in DataFlow::Node.#21491
Draft
aschackmull wants to merge 1 commit intogithub:mainfrom
Draft
C#: Reduce reliance on CFG nodes in DataFlow::Node.#21491aschackmull wants to merge 1 commit intogithub:mainfrom
aschackmull wants to merge 1 commit intogithub:mainfrom
Conversation
aschackmull
force-pushed
the
csharp/expr-dataflow2
branch
from
2460be6 to
b94c498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since splitting is almost abolished, it's generally simpler to base the data flow nodes on AST nodes rather than CFG nodes. CFG nodes still play a role, and they're still mixed up in calculating enclosing (data-flow) callables, and dealing with that is postponed for now to keep the size of the refactor in check.