feat(dashboards): text widget in widget builder + edit flows#110800
Draft
nikkikapadia wants to merge 2 commits intomasterfrom
Draft
feat(dashboards): text widget in widget builder + edit flows#110800nikkikapadia wants to merge 2 commits intomasterfrom
nikkikapadia wants to merge 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR puts the text widget form in the widget builder. We hide everything except for the title field, display type selector, and description field. All of this uses the session state text content. I've also made sure that all the edit flows send the text content into the session state and have tried to set it up so that if we have other fields like this in the future, the logic for opening the widget builder can handle this in one place.
examples: