Skip to content

[Flight] Pack deferred children into continuation rows #36053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhart wants to merge 1 commit into
base: main
Choose a base branch
from
+857 −74
Open

[Flight] Pack deferred children into continuation rows #36053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 44 additions & 3 deletions packages/react-client/src/__tests__/ReactFlight-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,38 @@ describe('ReactFlight', () => {
expect(readValue).toEqual(date);
});

it('should warn in DEV if an object with toJSON is passed as a top-level value', async () => {
const obj = {
toJSON() {
return 123;
},
};

const transport = ReactNoopFlightServer.render(obj);
assertConsoleErrorDev([
'Only plain objects can be passed to Client Components from Server Components. ' +
'Objects with toJSON methods are not supported. ' +
'Convert it manually to a simple value before passing it to props.\n' +
' {: {toJSON: ...}}\n' +
' ^^^^^^^^^^^^^',
]);

let readValue;
await act(async () => {
readValue = await ReactNoopFlightClient.read(transport);
});

expect(readValue).toBe(123);
assertConsoleErrorDev([
'Only plain objects can be passed to Client Components from Server Components. ' +
'Objects with toJSON methods are not supported. ' +
'Convert it manually to a simple value before passing it to props.\n' +
' {: {toJSON: ...}}\n' +
' ^^^^^^^^^^^^^\n' +
' at (<anonymous>)',
]);
});

it('can transport Error objects as values', async () => {
class CustomError extends Error {
constructor(message) {
Expand All @@ -670,7 +702,10 @@ describe('ReactFlight', () => {
is error: ${prop instanceof Error}
name: ${prop.name}
message: ${prop.message}
stack: ${normalizeCodeLocInfo(prop.stack).split('\n').slice(0, 2).join('\n')}
stack: ${normalizeCodeLocInfo(prop.stack)
.split('\n')
.slice(0, 2)
.join('\n')}
environmentName: ${prop.environmentName}
`;
}
Expand Down Expand Up @@ -716,7 +751,10 @@ describe('ReactFlight', () => {
is error: ${error instanceof Error}
name: ${error.name}
message: ${error.message}
stack: ${normalizeCodeLocInfo(error.stack).split('\n').slice(0, 2).join('\n')}
stack: ${normalizeCodeLocInfo(error.stack)
.split('\n')
.slice(0, 2)
.join('\n')}
environmentName: ${error.environmentName}
cause: ${'cause' in error ? renderError(error.cause) : 'no cause'}`;
}
Expand Down Expand Up @@ -782,7 +820,10 @@ describe('ReactFlight', () => {
is error: true
name: ${error.name}
message: ${error.message}
stack: ${normalizeCodeLocInfo(error.stack).split('\n').slice(0, 2).join('\n')}
stack: ${normalizeCodeLocInfo(error.stack)
.split('\n')
.slice(0, 2)
.join('\n')}
environmentName: ${error.environmentName}
cause: ${'cause' in error ? renderError(error.cause) : 'no cause'}`;
}
Expand Down
Loading