You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you! Just a quick question: should 1xx responses on non-streaming requests return? With this PR they do but I'm not sure that's intentional. (I think they should definitely return for streaming requests, though)
Here's the bit in specific I'm not sure about:
A client MUST be able to parse one or more 1xx responses received prior to a final response, even if the client does not expect one. A user agent MAY ignore unexpected 1xx responses.
Just a quick question: should 1xx responses on non-streaming requests return?
Yes, I think that's okay. You'll end up with a 101 response, with body that'll stream the network content.
At the httpx layer that'd typically effectively mean you'd get a 101 response, that'd then result in a read timeout waiting for some response content.
But you'd need to have sent an upgrade request in the first place, so you'd have to deliberately do odd things, and you'd end up in a reasonable failure state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by #572 (comment)