fix: respect DSN password over PGPASSWORD env var#1562
Open
BillionClaw wants to merge 1 commit intodbcli:mainfrom
Open
fix: respect DSN password over PGPASSWORD env var#1562BillionClaw wants to merge 1 commit intodbcli:mainfrom
BillionClaw wants to merge 1 commit intodbcli:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connecting via DSN URI containing a password (e.g.,
postgresql://user:pass@host/db), pgcli incorrectly prioritized the PGPASSWORD environment variable over the password embedded in the DSN. This caused authentication failures when PGPASSWORD was set to a different value.Changed the connection logic to check if the DSN contains a password before falling back to PGPASSWORD. If a password is present in the DSN, it takes precedence.
Fixes #1555