Enhance URI scheme validation for Windows paths#3161
Open
AlgoDeveloper400 wants to merge 1 commit intoapache:mainfrom
Open
Enhance URI scheme validation for Windows paths#3161AlgoDeveloper400 wants to merge 1 commit intoapache:mainfrom
AlgoDeveloper400 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: handle Windows drive letters in
parse_locationRationale for this change
When a Windows user passes a local file path like
C:\Users\file.avrotoPyArrowFileIO,Python's
urlparseincorrectly treats the Windows drive letterCas a URL scheme (likes3orhttp).This caused PyIceberg to crash with:
The Fix
Before ❌ (Original Code):
After ✅ (Fixed Code):
The only change:
The added condition checks if the scheme is a single alphabetic character (e.g.
C,D,E)and treats it as a Windows drive letter instead of a URL scheme.
Example
Impact
This fix affects all local file operations on Windows including:
Are these changes tested?
Yes - existing tests now pass on Windows.
tests/test_avro_sanitization.pytests/io/test_pyarrow.pyAre there any user-facing changes?
Yes - fixes local file access on Windows for all PyIceberg users.