Addition of description field for NIC's secondary IP addresses#12864
Open
erikbocks wants to merge 1 commit intoapache:mainfrom
Open
Addition of description field for NIC's secondary IP addresses#12864erikbocks wants to merge 1 commit intoapache:mainfrom
erikbocks wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #12864 +/- ##
=============================================
- Coverage 18.02% 3.53% -14.50%
=============================================
Files 5968 464 -5504
Lines 537086 40023 -497063
Branches 65961 7530 -58431
=============================================
- Hits 96819 1414 -95405
+ Misses 429347 38421 -390926
+ Partials 10920 188 -10732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to help users to identify more easily the reason that their NIC's secondary IP address were allocated to the VM, a description field was added to the secondary IPs. Now, during secondary IP address allocation, it is possible to inform a descriptive text, that will be displayed along with the IP address in the NIC details or in the API's responses.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Figure 1 - Form description field
Figure 2 - IP's description present at NIC details
How Has This Been Tested?
In an environment where the PR changes were installed, I opened the secondary IP addition tab and validated that the description field was added successfully to the form (Figure 1 in the
Screenshotstab). Via CMK, I validated that the description field was also added to theaddIpToNicAPI.Then, I added a secondary IP address to my VM with an example text in it (Figure 2). After that, I made some tests to features involving secondary IPs, as the addresses management and configuration, as well as a communication test with static NAT assigned to the secondary IP.
With CloudMonkey, I also validated that the description field was now returned in NICs' responses in the
listNicsAPI.