New config.json variable to set the ACS default language#12863
Open
hsato03 wants to merge 1 commit intoapache:mainfrom
Open
New config.json variable to set the ACS default language#12863hsato03 wants to merge 1 commit intoapache:mainfrom
hsato03 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@blueorangutan package |
|
@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12863 +/- ##
============================================
- Coverage 18.02% 18.02% -0.01%
+ Complexity 16450 16448 -2
============================================
Files 5968 5968
Lines 537086 537090 +4
Branches 65961 65961
============================================
- Hits 96819 96797 -22
- Misses 429347 429373 +26
Partials 10920 10920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to extend the
config.jsonfile with thedefaultLanguagevariable to allow the definition of the default language used by ACS.The default value of this variable is
en, meaning the default language will be English. To change the variable's value to other languages, it must be set with the language code of the desired language. For example, to set the default ACS language to Brazilian Portuguese, the variable should have the valuept_BR.Table of supported language codes
enhija_JPko_KRzh_CNarcade_DEesfr_FRit_IThunl_NLnb_NOplpt_BRru_RUel_GRTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
config.jsonfile by setting thedefaultLanguagevariable to the valueja_JP. Then, I opened the ACS GUI in an incognito tab and verified that ACS was in Japanese;pt_BR. Then, I opened the ACS GUI in an incognito tab and verified that ACS was in Brazilian Portuguese;defaultLanguagevariable from theconfig.jsonfile. Then, I opened the ACS GUI in an incognito tab and verified that the English language was still used by default.How did you try to break this feature and the system with this change?