Skip to content

Set management server id from cookies after saml login#12858

Open
sureshanaparti wants to merge 1 commit intoapache:4.22from
shapeblue:set-msid-after-saml-login
Open

Set management server id from cookies after saml login#12858
sureshanaparti wants to merge 1 commit intoapache:4.22from
shapeblue:set-msid-after-saml-login

Conversation

@sureshanaparti
Copy link
Contributor

Description

This PR sets the management server id from cookies after saml login. During saml login, management server id is not set and readyForShutdown API call from UI failing error - 'Invalid value provided for API arg: managementserverid'.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Verified the readyForShutdown API called from UI with proper managementserverid, after saml login.

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (e93ae1a) to head (5812c00).

Files with missing lines Patch % Lines
...ain/java/org/apache/cloudstack/saml/SAMLUtils.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12858   +/-   ##
=========================================
  Coverage     17.61%   17.61%           
  Complexity    15661    15661           
=========================================
  Files          5917     5917           
  Lines        531430   531433    +3     
  Branches      64973    64974    +1     
=========================================
+ Hits          93586    93589    +3     
+ Misses       427288   427287    -1     
- Partials      10556    10557    +1     
Flag Coverage Δ
uitests 3.70% <ø> (-0.01%) ⬇️
unittests 18.68% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants