Set management server id from cookies after saml login#12858
Open
sureshanaparti wants to merge 1 commit intoapache:4.22from
Open
Set management server id from cookies after saml login#12858sureshanaparti wants to merge 1 commit intoapache:4.22from
sureshanaparti wants to merge 1 commit intoapache:4.22from
Conversation
Contributor
Author
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12858 +/- ##
=========================================
Coverage 17.61% 17.61%
Complexity 15661 15661
=========================================
Files 5917 5917
Lines 531430 531433 +3
Branches 64973 64974 +1
=========================================
+ Hits 93586 93589 +3
+ Misses 427288 427287 -1
- Partials 10556 10557 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the management server id from cookies after saml login. During saml login, management server id is not set and readyForShutdown API call from UI failing error - 'Invalid value provided for API arg: managementserverid'.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Verified the readyForShutdown API called from UI with proper managementserverid, after saml login.
How did you try to break this feature and the system with this change?