Skip to content

Fix project-based network filtering in unmanaged instance import#12854

Open
dheeraj12347 wants to merge 10 commits intoapache:mainfrom
dheeraj12347:fix-import-vm-project-networks
Open

Fix project-based network filtering in unmanaged instance import#12854
dheeraj12347 wants to merge 10 commits intoapache:mainfrom
dheeraj12347:fix-import-vm-project-networks

Conversation

@dheeraj12347
Copy link

When importing unmanaged instances for a project, the UI should list only project networks in the network selection; currently account-level networks are also shown, causing the “no matching network” behavior described in the issue.

This change wires the project context into the multi-network selector so that the networks list respects the chosen project.

Implementation details

src/views/compute/wizard/MultiNetworkSelection.vue

Added a projectid prop and passed it through to the listNetworks API call parameters so that networks are filtered by the selected project when present.

src/views/tools/ImportUnmanagedInstance.vue

Passed form.projectid into via the new :projectid prop so that project selection is honored in the unmanaged instance import flow.

Testing

npm run lint

Passes; both modified Vue files were auto-fixed by the linter.

Backend / UI run attempts (blocked):

mvn -Pdeveloper -Dsimulator -DskipTests clean install fails in cloud-engine-schema at systemvm-template-metadata, so the simulator environment could not be fully built locally.

npm run serve on the current branch fails in DomainActionForm.vue with a “content” error, so the import unmanaged instance UI flow could not be exercised end-to-end.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (65e5409) to head (34bed7a).
⚠️ Report is 148 commits behind head on main.

Files with missing lines Patch % Lines
...tack/engine/orchestration/NetworkOrchestrator.java 0.00% 4 Missing and 1 partial ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12854      +/-   ##
============================================
+ Coverage     17.61%   18.02%   +0.41%     
- Complexity    15665    16451     +786     
============================================
  Files          5917     5968      +51     
  Lines        531400   537120    +5720     
  Branches      64970    65966     +996     
============================================
+ Hits          93603    96818    +3215     
- Misses       427244   429379    +2135     
- Partials      10553    10923     +370     
Flag Coverage Δ
uitests 3.53% <ø> (-0.18%) ⬇️
unittests 19.19% <0.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Import VM wizard doesn't list the project networks

7 participants