chore: exclude test directory from npm package#7
Open
veksen wants to merge 1 commit intoWebReflection:masterfrom
Open
chore: exclude test directory from npm package#7veksen wants to merge 1 commit intoWebReflection:masterfrom
veksen wants to merge 1 commit intoWebReflection:masterfrom
Conversation
The test/ directory is currently shipped to npm but is not needed by consumers. Adding it to .npmignore reduces the package size.
| .gitignore | ||
| .travis.yml | ||
| test | ||
| test.js |
Owner
There was a problem hiding this comment.
I think this was old case and forgot to update it to test ... mind removing this line as there is no test.js in here anymore anyway? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test/directory is currently included in the published npm package but is not needed by consumers.This PR adds
testto the existing.npmignoreto exclude it from the tarball, reducing the package size for all downstream users.Before:
After:
Test files no longer shipped.