Conversation
|
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
|
View your CI Pipeline Execution ↗ for commit 030ef7c
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-a11y
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughUpdates to Changesets config and CLI, devDependency bump, Nx config addition, and multiple GitHub Actions workflow adjustments including checkout version bumps, removal of PR path filters, added pull-request write permission, a Version Preview job, and a release PR comment step. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/pr.yml (1)
63-65: Pin cross-repo reusable workflow actions to immutable commit SHAs.The
TanStack/config/.github/setup@mainandTanStack/config/.github/changeset-preview@mainreferences on lines 63 and 65 use mutable branch pointers. Replace@mainwith a full commit SHA for better reproducibility and supply-chain safety.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pr.yml around lines 63 - 65, Replace the mutable branch references for the two reusable workflow actions so the workflow pins to immutable commit SHAs: find the uses entries referencing "tanstack/config/.github/setup@main" and "tanstack/config/.github/changeset-preview@main" and swap the "@main" suffix for the full commit SHA for each action (use the exact commit SHA from the upstream TanStack/config repo for the desired revisions) so both the setup and changeset-preview steps are pinned to specific commits.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr.yml:
- Around line 13-15: The top-level GitHub Actions permissions block currently
grants pull-requests: write globally; remove pull-requests: write from the
top-level permissions and instead add a job-level permissions block for the
version-preview job that includes pull-requests: write (keep contents: read at
top-level). Update the job named version-preview to include permissions: {
pull-requests: write, contents: read } (or merge with its existing permissions)
so only that job has write scope; also mirror the same change for the other
occurrence noted around lines 56-65 by removing global write and scoping write
to the specific job(s).
---
Nitpick comments:
In @.github/workflows/pr.yml:
- Around line 63-65: Replace the mutable branch references for the two reusable
workflow actions so the workflow pins to immutable commit SHAs: find the uses
entries referencing "tanstack/config/.github/setup@main" and
"tanstack/config/.github/changeset-preview@main" and swap the "@main" suffix for
the full commit SHA for each action (use the exact commit SHA from the upstream
TanStack/config repo for the desired revisions) so both the setup and
changeset-preview steps are pinned to specific commits.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3c8e8d56-9f24-4515-915d-5bf2c406b340
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
.changeset/config.json.github/workflows/autofix.yml.github/workflows/pr.yml.github/workflows/release.ymlnx.jsonpackage.json
| permissions: | ||
| contents: read | ||
| pull-requests: write |
There was a problem hiding this comment.
Scope PR write permission to the Version Preview job only.
Line 15 grants pull-requests: write to every job, including jobs executing third-party tooling. Restrict it to version-preview to reduce token blast radius.
🔐 Proposed least-privilege adjustment
permissions:
contents: read
- pull-requests: write
jobs:
test:
@@
version-preview:
name: Version Preview
runs-on: ubuntu-latest
+ permissions:
+ contents: read
+ pull-requests: write
steps:
- name: Checkout
uses: actions/checkout@v6.0.2Also applies to: 56-65
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/pr.yml around lines 13 - 15, The top-level GitHub Actions
permissions block currently grants pull-requests: write globally; remove
pull-requests: write from the top-level permissions and instead add a job-level
permissions block for the version-preview job that includes pull-requests: write
(keep contents: read at top-level). Update the job named version-preview to
include permissions: { pull-requests: write, contents: read } (or merge with its
existing permissions) so only that job has write scope; also mirror the same
change for the other occurrence noted around lines 56-65 by removing global
write and scoping write to the specific job(s).
🎯 Changes
Sync changes from other TanStack projects
Add changeset version preview (see TanStack/router#6937 and TanStack/config#356)
✅ Checklist
pnpm test:pr.🚀 Release Impact
Summary by CodeRabbit