Skip to content

Fix Pad fast type error#719

Open
SharonStrats wants to merge 6 commits intomainfrom
fix/fasttype-pad
Open

Fix Pad fast type error#719
SharonStrats wants to merge 6 commits intomainfrom
fix/fasttype-pad

Conversation

@SharonStrats
Copy link
Contributor

@SharonStrats SharonStrats commented Mar 19, 2026

Ticket: #21

This should resolve the error we get when typing fast in the pad.

it was tested in solid-panes by changing the files there. I'm not sure how to test now that we don't get the build artifacts.

Copilot AI review requested due to automatic review settings March 19, 2026 03:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent the notepad (“pad”) from getting into a broken state when a user types quickly and upstream updates lag, as described in Issue #21.

Changes:

  • Debounces input events before sending PATCH updates to the server.
  • Adds limited retry behavior for transient upstream failures (e.g., 502/503).
  • Applies various formatting/string-literal cleanups in src/pad.ts.
Comments suppressed due to low confidence (1)

src/pad.ts:391

  • xhr is treated as always present, but UpdateManager.update callbacks in this repo are often invoked without an XHR/Response argument (many callsites only use 3 params). The log line and the === 409 check dereference (xhr as any).status without guarding, which will throw on network-level failures where xhr is undefined/null. Please use optional chaining/fallbacks consistently (e.g., derive status once and use it for logging and branching).
          log(
            '    patch FAILED ' +
              (xhr as any).status +
              " for '" +
              old +
              "' -> '" +
              newOne +
              "': " +
              errorBody
          )
          if ((xhr as any).status === 409) {
            // Conflict -  @@ we assume someone else
            setPartStyle(part, 'color: black;  background-color: #fdd;')

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

SharonStrats and others added 5 commits March 19, 2026 14:11
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants