Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent the notepad (“pad”) from getting into a broken state when a user types quickly and upstream updates lag, as described in Issue #21.
Changes:
- Debounces
inputevents before sending PATCH updates to the server. - Adds limited retry behavior for transient upstream failures (e.g., 502/503).
- Applies various formatting/string-literal cleanups in
src/pad.ts.
Comments suppressed due to low confidence (1)
src/pad.ts:391
xhris treated as always present, butUpdateManager.updatecallbacks in this repo are often invoked without an XHR/Response argument (many callsites only use 3 params). The log line and the=== 409check dereference(xhr as any).statuswithout guarding, which will throw on network-level failures wherexhris undefined/null. Please use optional chaining/fallbacks consistently (e.g., derivestatusonce and use it for logging and branching).
log(
' patch FAILED ' +
(xhr as any).status +
" for '" +
old +
"' -> '" +
newOne +
"': " +
errorBody
)
if ((xhr as any).status === 409) {
// Conflict - @@ we assume someone else
setPartStyle(part, 'color: black; background-color: #fdd;')
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…into fix/fasttype-pad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #21
This should resolve the error we get when typing fast in the pad.
it was tested in solid-panes by changing the files there. I'm not sure how to test now that we don't get the build artifacts.