Run all tests in wasm except for credentials tests#123
Merged
JohanMabille merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 60 60
Lines 2619 2619
Branches 309 309
=======================================
Hits 2311 2311
Misses 308 308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Results of manual WebAssembly test run: ================== 249 passed, 9 skipped in 435.51s (0:07:15) ================== |
JohanMabille
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that all tests are run in WebAssembly except for the credentials tests, support for which will follow in another PR.
Summary of changes:
diff,fetch,pushandtag).os.rename,os.symlinkandPath.write_bytes.strip_ansi_colourswhich removes ANSI colour sequences from a string. This is needed because by default the normal linux/macos tests do not include colour sequences but the wasm ones do, so tests that check the contents ofstdoutreturned bygit2cppfunctions need to remove colour sequences that are added. In future I am intending that we have some tests with and some without colour sequences for both the normal and wasm tests.envinsubprocess.runas thecommit_env_configfixture does this automatically.