Skip to content

exec::sequence: Exception Correctness#1878

Merged
ericniebler merged 7 commits intoNVIDIA:mainfrom
RobertLeahy:sequence_20260220
Mar 3, 2026
Merged

exec::sequence: Exception Correctness#1878
ericniebler merged 7 commits intoNVIDIA:mainfrom
RobertLeahy:sequence_20260220

Conversation

@RobertLeahy
Copy link
Contributor

@RobertLeahy RobertLeahy commented Feb 21, 2026

Corrected two exception-related problems with exec::sequence:

  • Previously exec::sequence senders unconditionally reported that they could throw when connected
  • Previously exec::sequence senders unconditionally reported that they could send set_error_t(std::exception_ptr), updated so this is now reported only if it's possible (i.e. if a child sender has that completion, or if any child sender other than the first possibly throws when connected)

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 21, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Corrected two exception-related problems with exec::sequence:

- Previously exec::sequence senders unconditionally reported that they
  could throw when connected
- Previously exec::sequence senders unconditionally reported that they
  could send set_error_t(std::exception_ptr), updated so this is now
  reported only if it's possible (i.e. if a child sender has that
  completion, or if any child sender other than the first possibly
  throws when connected)
@RobertLeahy RobertLeahy changed the title exec::sequence: Conditionally Report set_error_t(std::exception_ptr) exec::sequence: Exception Correctness Feb 21, 2026
@ericniebler
Copy link
Collaborator

/ok to test 6ac7829

@ericniebler ericniebler self-requested a review March 3, 2026 01:47
@ericniebler
Copy link
Collaborator

/ok to test 8e38692

@ericniebler
Copy link
Collaborator

/ok to test 0ea16f9

@ericniebler
Copy link
Collaborator

/ok to test 6a1ae4d

@ericniebler ericniebler merged commit d819022 into NVIDIA:main Mar 3, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants