Merged
Conversation
Member
|
如果是第二种最好在requirement里边加一个 griffe 版本限制 |
Contributor
Author
那要不就直接锁到 >=1.0 版本? |
Member
这个要不然先兼容一下两个版本吧,这个1.0的版本有点新,没发布几天就更新了1.1 感觉不是很稳定 |
Contributor
Author
更新了一版 import 逻辑,辛苦佬再看看 |
Harold-lkk
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由于 griffe1.0.0 移除了 griffe.enumerations,所以需要修改此处 import。
两种修改方法:
本 PR 目前使用了第二种方法。如果佬们觉得第一种方法更合适,可以留下 comment,我来修改为第一种。