[feature] support brave search api and refractor google serper api in BingBroswer#233
Merged
Harold-lkk merged 8 commits intoInternLM:mainfrom Aug 26, 2024
tackhwa:main
Merged
[feature] support brave search api and refractor google serper api in BingBroswer#233Harold-lkk merged 8 commits intoInternLM:mainfrom tackhwa:main
Harold-lkk merged 8 commits intoInternLM:mainfrom
tackhwa:main
Conversation
Contributor
tackhwa
commented
Aug 15, 2024
tackhwa
commented
- new support feature is as title, google serper api had been refractor so that the response return by the function is having consistent formatting and will not throw an error when using google serper api in MindSearch.
- both brave search api and refactored google serper api had been tested on MindSearch with no error.
Harold-lkk
reviewed
Aug 19, 2024
Contributor
Author
|
已加docstring |
Harold-lkk
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.