make it use the right bucket name#518
Merged
BigSpaceships merged 3 commits intodevelopfrom Mar 18, 2026
Merged
Conversation
Contributor
Author
|
Sonarqube is a nonissue, I told it it was okay but it won't update the thing |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
BigSpaceships
added a commit
that referenced
this pull request
Mar 18, 2026
* make it use the right bucket name * expected owner arg * making sonarqube happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bugs where the
S3_BUCKET_IDis unusedWhy
It wouldn't work for the right database
Test Plan
Tried a different bucket than the dev one (it works)
Env Vars
Nope
Documentation
Nope
Checklist