Fix table of contents instances#762
Merged
shawnbot merged 8 commits intorelease-12.4.1from May 22, 2019
Merged
Conversation
shawnbot
reviewed
Apr 23, 2019
Contributor
|
Looks like this didn't make it. I'll switch the base branch back to |
Contributor
|
Thanks, @simurai. Let's see if updating the branch re-runs actions and makes everything green. If so, we can merge this right to master. |
simurai
previously requested changes
May 3, 2019
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
Tested this on now.sh and it seems that the "Table of Contents" links don't work. I think it's because the links in the toc are lowercase, but the IDs on the page are uppercase.
- Link in toc: https://primer-css-fix-toc.now.sh/css/components/labels#labels
- 🔗 Link icon on the page: https://primer-css-fix-toc.now.sh/css/components/labels#Labels
added 2 commits
May 7, 2019 14:53
shawnbot
approved these changes
May 7, 2019
Contributor
shawnbot
left a comment
shawnbot
left a comment
There was a problem hiding this comment.
Awesome, thank you! It's a little bit annoying that the sticky header covers up most of the titles when you link to them, but at least the links work now! 🚀
This was referenced Dec 15, 2022
This was referenced Dec 20, 2022
This was referenced Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the remark/toc plugin for table of contents on documentation pages, instead of our
Outlinecomponent.